Global notifications #970
Merged
Global notifications #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmijatovic
force-pushed
the
rsd-v2-release
branch
from
6f49303
to
ab1edac
Compare
dmijatovic
force-pushed
the
maintenance-notice
branch
3 times, most recently
from
c9e98ac
to
4d87b72
Compare
dmijatovic
approved these changes
Aug 29, 2023
jmaassen
reviewed
Aug 29, 2023
…ts for future test purposes and use theme colors.
cmeessen
force-pushed
the
maintenance-notice
branch
from
5afddcf
to
a9704a7
Compare
There was a problem hiding this comment.
A few comments/suggestions, but non are deal breaking, so let me know if and what you want to do with them.
- Since the text is set by admins only, consider removing the 200 char limit.
- In the frontend, I cannot fully remove the text, I can only make it invisible, is this intentional?
- Consider enforcing allowing only one row to exist in this table, see e.g.
017-create-narcis-table.sqlfor how to to this, this also allows you to drop the UUID column.
cmeessen
force-pushed
the
maintenance-notice
branch
from
dda60b0
to
a567a45
Compare
|
[rsd-database] Kudos, SonarCloud Quality Gate passed!
|
|
@ewan-escience thank you for the suggestions. I applied the database trick which is quite neat. As for the text, I think it does make sense to not be able to completely remove it in the frontend. Otherwise, one might accidentally end up with an empty notification bar. If there is nothing else, this PR is ready to be merged. |
|
[rsd-frontend] Kudos, SonarCloud Quality Gate passed! |
ewan-escience
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
How to test:
make startto build app and generate test datawarningcolors defined in the settings (light theme).Example admin section
Example announcement
PR Checklist:
docker-compose.yml